search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Remove service principal authentication from McrStatusClient #1269

Closed lbussell closed 4 months ago

lbussell commented 4 months ago

Part of #1264

I haven't tested this in-place yet since it only runs on real builds, so marking as a draft for now. Early next week I'll run a test by modifying a pipeline to skip publishing and just check the status of some existing build.

lbussell commented 4 months ago

Tried to queue a test but I'm not sure it did anything [internal link] - https://dev.azure.com/dnceng/internal/_build/results?buildId=2444600&view=logs&j=739bb7ec-7296-5b40-7dff-ee3297bfdaa4&t=487ef77f-c8ee-5b2f-147b-5cff06a12f4e

Any other tips for testing this @mthalman? Or since it wouldn't block publishing should we just merge it and revert if there are any big issues?

mthalman commented 4 months ago

Tried to queue a test but I'm not sure it did anything [internal link] - https://dev.azure.com/dnceng/internal/_build/results?buildId=2444600&view=logs&j=739bb7ec-7296-5b40-7dff-ee3297bfdaa4&t=487ef77f-c8ee-5b2f-147b-5cff06a12f4e

Any other tips for testing this @mthalman? Or since it wouldn't block publishing should we just merge it and revert if there are any big issues?

It didn't do anything because no images were published (due to image caching). You could test this by running Image Builder locally targeting the image info file from a previous publish run.