search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Migrate AcrClient to Azure.Containers.ContainerRegistry #1272

Closed mthalman closed 4 months ago

mthalman commented 4 months ago

This replaces the AcrClient class with use of the clients available from the Azure.Containers.ContainerRegistry package. The AcrClient class was used by CleanAcrImagesCommand. So these changes update CleanAcrImagesCommand to make use of IContainerRegistryClientFactory acrClientFactory and IContainerRegistryContentClientFactory instead of IAcrClientFactory. Two client types are needed for the implementation because Azure.Containers.ContainerRegistry splits the API that way. ContainerRegistryClient provides the access to repositories and ContainerRegistryContentClient provides the access to manifests.

These changes include the deletion of all the AcrClient implementation, including all of the related model classes.

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.