Perf improvements for CleanAcrImagesCommand

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.

MIT License

122 stars 46 forks source link

Perf improvements for CleanAcrImagesCommand #1275

Closed mthalman closed 4 months ago

mthalman commented 4 months ago

The CleanAcrImagesCommand command makes use of IAsyncEnumerable but it does so in a blocking manner. This causes poor performance in the build job that consumes that command. In one scenario it's taking 23 minutes to run when the previous implementation (prior to https://github.com/dotnet/docker-tools/pull/1272) was taking just 3 minutes.

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 4 months ago

Merging in latest now to start PR validation.