search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
103 stars 42 forks source link

Use pipeline variable to reference MAR Status API resource/scope #1288

Open lbussell opened 1 month ago

lbussell commented 1 month ago

Currently we hardcode the resource scope for the MAR status API: https://github.com/dotnet/docker-tools/blob/7b8f03267f6687fd6ecf7bca1071f74536c1cfa6/src/Microsoft.DotNet.ImageBuilder/src/McrStatusClient.cs#L20

This is very inflexible and requires changes to our source code if we need to change where this points to. Instead, we should accept a scope via the CLI and pass it in via an environment variable so that we can change it as needed without rebuilding ImageBuilder. We don't intend to frequently access this API on dev machines, so this should be an acceptable solution.

dotnet-issue-labeler[bot] commented 1 month ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

mthalman commented 1 month ago

It would probably make sense to define this in our Dotnet-Docker-Common variable group.