dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

Remove Build command requirement for service principal #1293

Closed lbussell closed 5 months ago

lbussell commented 6 months ago

Sorry this PR is so large!

Related: https://github.com/dotnet/docker-tools/issues/1264

Notes:

TODO:

dotnet-issue-labeler[bot] commented 6 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 5 months ago

The force push contains no changes, I just did a rebase instead of a merge by accident.

I ran a sanity check of the build command and it seems OK - [internal link] - another one without Windows so it can run publishing commands

We should merge to get the actual ImageBuilder image built and continue validating. We can address https://github.com/dotnet/docker-tools/issues/1296 at a later date.