Closed lbussell closed 5 months ago
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
The force push contains no changes, I just did a rebase instead of a merge by accident.
I ran a sanity check of the build command and it seems OK - [internal link] - another one without Windows so it can run publishing commands
We should merge to get the actual ImageBuilder image built and continue validating. We can address https://github.com/dotnet/docker-tools/issues/1296 at a later date.
Sorry this PR is so large!
Related: https://github.com/dotnet/docker-tools/issues/1264
Notes:
DockerService
never needs auth,ManifestService
uses auth when we have it, therefore I've separated the two classes out so thatDockerService
is never concerned about auth.ManifestService
(nowInnerManifestService
) so extension methods can be mocked for testing (DockerService
previously served this function).ManifestServiceFactory
to handle passing auth to theManifestService
in one place.RegistryCredentialsProvider
which uses logic similar toRegistryContentClientFactory
to dynamically get username/password fordocker login
.TODO:
RegistryContentClientFactory
Tests are failing