search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Code fixup #1315

Closed nimanikoo closed 3 months ago

nimanikoo commented 4 months ago

Hello, I hope you are well Thank you for helping open source and building this project for the .NET community Out of curiosity, I was reviewing the codes of this repository and I found some points that might be good to correct. The next thing is that you can use the primary constructor according to the latest version of .NET In some cases, we could have written the code in a more concise and readable manner and used expressions I am endeavoring to that the latest features and updates in the .NET ecosystem are seamlessly integrated into the project without conflicts. It's my goal to contribute to the continuous improvement of this project. I hope these things are helpful and I will be happy to contribute to the progress of this project Please check and let me know the result

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 3 months ago

Hi @nimanikoo, thanks for the contribution. We generally prefer that community contributors file issues proposing changes before submitting PRs. I realize that this repo has no CONTRIBUTING.md file outlining that preference. That's because this is mostly internal tooling for the .NET Containers team.

This specific tool is not unit tested. Any potential regressions in this PR wouldn't be surfaced until we need to run this code again which could cause breaks in our infrastructure. Since this code works in its current form, I think it's just best to leave it until we need to make other changes, rather than making changes for the sake of making changes.

If you still want to contribute to .NET, the Runtime repo has a good guide on where and how to contribute: https://github.com/dotnet/runtime/blob/main/CONTRIBUTING.md