dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

Stop mirroring images that are already on Azure Container Registries #1332

Closed lbussell closed 5 months ago

lbussell commented 5 months ago

The CopyBaseImagesCommand logic copies images indiscriminately. The intention is for that logic to mirror images that are subject to rate-limiting (i.e. from DockerHub). Some of the images we use are now located in Azure Container Registries by default, like azurelinuxpreview.azurecr.io and ubuntu.azurecr.io. These should not be mirrored since they are not affected by rate-limiting the same as other images.

mthalman commented 5 months ago

This was intentional.

  1. It keeps the implementation simple.
  2. It ensures that we are unblocked if any of the 3rd party registries are unavailable.