search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
103 stars 42 forks source link

Simplify various GitHub library usages #1335

Open lbussell opened 2 weeks ago

lbussell commented 2 weeks ago

ImageBuilder uses 3 separate GitHub libraries:

Microsoft.DotNet.VersionTools.Automation.GitHubApi: https://github.com/dotnet/docker-tools/blob/93ef66423ed62d4dd1fd5419590cfa765f322d30/eng/src/file-pusher/FilePusher.cs#L17

Microsoft.DotNet.Git.IssueManager: https://github.com/dotnet/docker-tools/blob/93ef66423ed62d4dd1fd5419590cfa765f322d30/src/Microsoft.DotNet.ImageBuilder/src/NotificationService.cs#L9

and OctoKit: https://github.com/dotnet/docker-tools/blob/93ef66423ed62d4dd1fd5419590cfa765f322d30/src/Microsoft.DotNet.ImageBuilder/src/BlobsClientExtensions.cs#L7

We should consolidate all of these separate use-cases into a single library. That library should ideally be accessed through a wrapper class, so that we can eventually easily migrate to the generated GitHub SDK for .NET.

dotnet-issue-labeler[bot] commented 2 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 2 weeks ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.