search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Allow readmes to have tags header w/o tags table #1347

Closed mthalman closed 3 months ago

mthalman commented 3 months ago

Readme generation doesn't allow a readme to contain the Full Tag Listing header w/o also injecting the tags table. This blocks the implementation of https://github.com/dotnet/dotnet-docker/pull/5585. See https://github.com/dotnet/dotnet-docker/pull/5585#discussion_r1647680272.

In such a scenario where a readme has the header but not the end of tags marker, it essentially duplicates much of the readme and prepends it, along with the tags table. I've updated the logic to check if the end of tags marker is not present and not inject the tags table in that case. (The original intent was to throw if this marker was missing but there was a bug there preventing that from happening.)

dotnet-issue-labeler[bot] commented 3 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 3 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.