search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

Prepopulate token cache for publishManifest cmd #1354

Closed mthalman closed 4 months ago

mthalman commented 4 months ago

The publishManifest command ran into the same issue as the build command. See example build (internal link). In this case, there were numerous errors while pushing the manifests which resulted in a lot of retries. Those retries eventually succeeded but the overall effect was that the command took a long time to run. At the end of the command, it attempts to query the registry to get the digests and the token had expired due to the length of time.

The fix is to follow the same pattern that was done to fix the build command with https://github.com/dotnet/docker-tools/pull/1352.

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.