dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

CleanAcrImages: don't use dry run for login #1389

Closed mthalman closed 3 months ago

mthalman commented 3 months ago

The changes in https://github.com/dotnet/docker-tools/pull/1385 added a docker login call to ensure credentials were configured for calling oras. But this doesn't work when executing the image-clean pipeline in dry run mode. When dry run is set to true for the login call, it doesn't actually invoke the command. So no login occurs and the subsequent oras calls all fail.

This change explicitly sets dry run to false for the login command.