dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

Fix dry run logic in publishImageInfo #1437

Closed mthalman closed 2 months ago

mthalman commented 2 months ago

The changes from https://github.com/dotnet/docker-tools/pull/1434 cause issues in the pipeline when dry run is enabled because the generateEolAnnotationData command that gets executed after it expects those files to exist. But in dry run, those files are not written to.

This is fixed by moving the check for dry run so that it is after those files get written to.

dotnet-issue-labeler[bot] commented 2 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 2 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.