dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
125 stars 47 forks source link

Add special logic to handle tsa config in common build template #1468

Closed MichaelSimons closed 1 month ago

MichaelSimons commented 1 month ago

Fixes https://github.com/dotnet/dotnet-docker/issues/5967

The underlying issue was that the tsa config's path location is variable depending on whether or not the pipeline has multiple repos. The AzDO checkout step behaves differently if there are multiple repos being cloned versus a single. There is no built in variables to determine the default repos path.

Because of this the tsa config file's path cannot be easily determined in the 1es-official.yml in order to specify a custom config path parameter. Given the 1es-official template is used in a variety of scenarios and that our build logic is encapsulated in templates, it makes it difficult to cleanly implement a robust solution therefore it was decided to copy the tsa config option in the build scenario when multiple repos are involved.

I did test this within the buildtools repo with and without a tsaoptions.json file.

lbussell commented 1 month ago

@MichaelSimons OK to merge?