dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
125 stars 47 forks source link

EOL annotation fails when EOL Dockerfiles exist but images do not exist in ACR #1507

Open mthalman opened 2 hours ago

mthalman commented 2 hours ago

There can be circumstances where the EOL annotation logic will fail when attempting to query the metadata about an image in the ACR, where the image does not exist.

This occurs when the following conditions occur:

The issue here is in the generateEolAnnotationData command. It will see that the EOL Dockerfiles exist and that they should be added to the list of digests to be annotated here: https://github.com/dotnet/docker-tools/blob/6c08c3f30f8a88e21e5539d37ce5133a61aaa049/src/Microsoft.DotNet.ImageBuilder/src/Commands/GenerateEolAnnotationDataCommand.cs#L204-L229. The problem is that the images shouldn't have been added in the first place, or at least checked to see whether they exist before attempting to get their metadata.

Example failing build (internal link)

dotnet-issue-labeler[bot] commented 2 hours ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 2 hours ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.