search

dotnet / docs-tools

This repo contains GitHub Actions and other tools that are designed to be invoked on DocFx repositories.
Creative Commons Attribution 4.0 International
16 stars 28 forks source link

Fix two production bugs #322

Closed BillWagner closed 6 months ago

BillWagner commented 6 months ago

First problem: If the config file was missing any info, the whole operation failed. These should have been resilient and used the defaults, but no.

Second problem: If a work item didn't have a parent, the existing relation didn't exist, and the "remove relation" patch failed.

Remove the required modifier on the optional properties. That fixed the first issue.

For the second issue, use 0 as an invalid parent ID, instead of null. Fix the import logic to match.

Now, for both the current parent and the updated parent, 0 is invalid. Any other value is expected to be a valid work item.