dotnet / docs

This repository contains .NET Documentation.
https://learn.microsoft.com/dotnet
Creative Commons Attribution 4.0 International
4.26k stars 5.89k forks source link

Broken example formatting #16086

Open paulomorgado opened 4 years ago

paulomorgado commented 4 years ago

The example for ThreadState has its formatting broken.

And it doesn't seem to have an up to date output.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

mairaw commented 4 years ago

I don't have SOS configured right now. Do you have an up to date output I could use to update the article?

/cc @vivmishra who could help me to get an updated output for the ThreadState example?

paulomorgado commented 4 years ago

I've got this:

0:072> !threads
ThreadCount:      170
UnstartedThread:  0
BackgroundThread: 92
PendingThread:    0
DeadThread:       78
Hosted Runtime:   no
                                                                                                        Lock  
       ID OSID ThreadOBJ           State GC Mode     GC Alloc Context                  Domain           Count Apt Exception
   8    1 53ec 00000038029fc240    28220 Preemptive  0000000000000000:0000000000000000 00000038029f09f0 0     Ukn 
...
0:072> !threadstate 28220
    Legal to Join
    Background
    In Multi Threaded Apartment
    Fully initialized

Adding an explanation for all the sates would be nice too.

dotnet-bot commented 3 years ago

This issue has been closed as part of the issue backlog grooming process outlined in #22351.

That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs team for visibility.

mairaw commented 3 years ago

Fixing the sample formatting should be an easy fix.

BillWagner commented 3 years ago

reopening per request.

This is not quite as simple because the sample is in a table, so it will need to be moved out of the table to make the proper formatting.