search

dotnet / docs

This repository contains .NET Documentation.
https://learn.microsoft.com/dotnet
Creative Commons Attribution 4.0 International
4.27k stars 5.9k forks source link

Fix Link to Sample Application in Microsoft Document #3623

Closed MohitGargMSFT closed 5 years ago

MohitGargMSFT commented 6 years ago

Fix Link to Sample Application in Microsoft Document

Regarding this document - https://docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/how-to-localize-an-application

in above document , in Create a Sample Application section Link to LocBaml Tool Sample does not work

edit by @mairaw: added docs info below

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

wadepickett commented 6 years ago

@rpetrusha, please make sure this one gets assigned soon.

mairaw commented 6 years ago

I've asked @mohit14mar to file this one. I need to follow up with the product team to see if there's a good replacement for this. It could be https://github.com/Microsoft/WPF-Samples/tree/master/Globalization%20and%20Localization/BAML%20Loc.

manojsubramani commented 6 years ago

Could it be this? https://github.com/Microsoft/WPF-Samples/tree/master/Getting%20Started/HelloWorld

mairaw commented 6 years ago

@SamBent @sachingo can you guys help us find where the LocBaml tool is now located or if it was deleted? Our old link http://go.microsoft.com/fwlink/?LinkID=160016 no longer works. My guess would be https://github.com/Microsoft/WPF-Samples/tree/master/Globalization%20and%20Localization/BAML%20Loc.

rabanti-github commented 6 years ago

Hi I found the original source code of the locbaml tool on github. However, I am not sure whether the author published these sources on behalf of Microsoft or “by accident”. I don’t want to get this person into trouble by pointing at him/her. Therefore, just search for “locbaml” in github and you find it.

Is there a license for the locbaml tool? The source files are only annotated with “Copyright (c) Microsoft Corporation. All rights reserved.“ And no license information seems to be available.

mairaw commented 6 years ago

@rabanti-github if you're talking about the one I pointed earlier (https://github.com/Microsoft/WPF-Samples/tree/master/Globalization%20and%20Localization/BAML%20Loc), that repo has an MIT license.

The one I could find on GitHub (https://github.com/JeremyDurnell/locbaml) doesn't seem official.

@SamBent can you confirm which link should we use to replace https://archive.msdn.microsoft.com/Project/Download/FileDownload.aspx?ProjectName=wpfsamples&DownloadId=9333? Does my suggestion to point to https://github.com/Microsoft/WPF-Samples/tree/master/Globalization%20and%20Localization/BAML%20Loc sounds good?

rabanti-github commented 6 years ago

The unofficial project seems to be originating from Microsoft. I assume it was the old locBaml sample project mentioned (among others) in: https://docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/how-to-localize-an-application. All described features in this tutorial seems to be implemented in this unofficial project.

The other project seems however not to be a proper replacement. https://github.com/Microsoft/WPF-Samples/tree/master/Globalization%20and%20Localization/BAML%20Loc/LocApp has almost no content when it comes to code. It is only a WPF window with two text blocks. Localization features are not even implemented there. Is it planned to update this project?

I am a little bit clueless at the moment.

Edit: Maybe just to clarify.

Currently, almost all available tutorials (provided by Microsoft, as well as independent pages) in English, regarding WPF localization are pointing on the discussed locBaml example project as way to go for application localization. And this example is not available anymore officially. Thus, at the moment, the whole documentation about WPF localization is technically not available, not applicable, respectively.

I am not asking to add the source code of https://github.com/JeremyDurnell/locbaml to the official Microsoft repository. It just looks like this git repository is the only available source code in the Internet beside a further copy discovered on a Chinese coding board.

The easiest way to resolve this problem would be to search for the old source code (of the locBaml example) in the Microsoft archives and to re-publish it officially. If a new example project is introduced, all existing tutorials regarding localization are outdated and must be updated as well.

mairaw commented 5 years ago

I'm marking this one as blocked. @vatsan-madhavan could you help us figure out if we published or intend to publish this LocBaml tool sample? Please see issue history for more context.

/cc @OliaG

vatsan-madhavan commented 5 years ago

Sorry for missing this thread for several days.

Would you mind opening an issue for this at https://github.com/dotnet/wpf - asking for LocBaml to be published ?

LocBaml is part of WPF's test corpus - and would have eventually made it out to the open. I don't think we planned on putting it out anytime soon, but we can look into the feasibility of doing so. I know there is interest in one other tool from our test corpus (the VS team would like BamlReflector to be open-sourced sooner, for e.g.).

mairaw commented 5 years ago

No worries @vatsan-madhavan. Issue filed: https://github.com/dotnet/wpf/issues/498