dotnet / docs

This repository contains .NET Documentation.

https://learn.microsoft.com/dotnet

Creative Commons Attribution 4.0 International

4.13k stars 5.8k forks source link

Fix #40628 #40629

Closed jessicah closed 1 week ago

jessicah commented 2 weeks ago

Summary

Code example for the dotnet-8 pivot is a copy of the previous code example. Compiled example locally with .net8 sdk and copied generated code into docs.

Fixes https://github.com/dotnet/docs/issues/40628

Internal previews

📄 File	🔗 Preview link
docs/standard/base-types/regular-expression-source-generators.md	.NET regular expression source generators

BillWagner commented 1 week ago

@adegeo Can you take a look and resolve the conflicts here?

adegeo commented 1 week ago

@jessicah It looks like this was fixed a few weeks ago but was slow to merge and it just happened to land around the same time you opened this PR. That's where the merge conflict is from.

40566

I'm going to closet his PR. Thank you so much for taking the time to submit it!