Closed sakno closed 9 months ago
What do you think about adding an empty console app project to the solution that just serves the purpose of testing for trimming errors in all the DotNext.*
assemblies? Something like what I do here, based on the official recommendations. It just makes it a bit easier to do in-repo testing of trimming behavior, since the Roslyn analyzer doesn't necessarily catch everything.
Sounds reasonable.
Ok, I pushed the addition of that project to my fork: https://github.com/alexrp/dotNext/commit/af824cea8b7561ffe22950834f7ac012f993ca61
As expected, dotnet publish -p:TrimmerSingleWarn=false
in that project uncovered some problems that the Roslyn analyzer didn't catch:
Any of these you'd prefer to tackle? If not, I'll take a look over the next few days.
There are few warnings related to DotNext
core library that can be fixed easily. I'll do that later after merging this PR. The primary focus of this PR is to fix trimming errors in DotNext.Metaprogramming
.
Feel free to modify a branch linked to this PR directly.
Feel free to modify a branch linked to this PR directly.
Can I actually do that? :eyes: I tried pushing the commit to your feature branch here first, but GitHub rejected that due to permissions. I don't know if there's some other way to do it. :thinking:
rejected that due to permissions
Perhaps, you never contributed to this repository and didn't pass CLA check. I'll close this PR without merge. Could you please open a new one with your branch and merge changes from this branch?
Yep, will do.
Addresses #217
Scope of work:
DynamicDependency
andDynamicallyAccessedMembers
where applicableRequiresUnreferencedCode
otherwise