search

dotnet / dotNext

Next generation API for .NET
https://dotnet.github.io/dotNext/
MIT License
1.56k stars 119 forks source link

AsyncReaderWriterLock overload parity between Enter and Acquire #240

Closed cmeeren closed 3 weeks ago

cmeeren commented 4 weeks ago

In EnterReadLockAsync, there is one overload accepting a token, and another accepting a timeout and a token.

In AcquireReadLockAsync, there is one overload accepting a token, and another accepting a timeout, but not one accepting both.

The same is true for AcquireLockAsync and AcquireWriteLockAsync.

It would be great if the Acquire methods had overloads accepting both a timeout and a token.

cmeeren commented 3 weeks ago

Thanks! 😊👍