dotnet / dotnet-api-docs

.NET API reference documentation (.NET 5+, .NET Core, .NET Framework)
https://docs.microsoft.com/dotnet/api/
Other
725 stars 1.56k forks source link

Update `ILogger` documentation to clarify formatter behavior when using extension methods #10345

Closed enioluwas closed 1 month ago

enioluwas commented 2 months ago

Summary

As described in the issue, the ILogger extension methods defined in LoggerExtensions pass in a formatter that ignores the exception parameter passed in. This is being made clear so that developers do not assume otherwise.

Fixes #10318

dotnet-policy-service[bot] commented 2 months ago

Tagging subscribers to this area: @dotnet/area-extensions-logging

learn-build-service-prod[bot] commented 2 months ago

Learn Build status updates of commit dd3cbfb:

:white_check_mark: Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Logging/ILogger.xml :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

learn-build-service-prod[bot] commented 2 months ago

Learn Build status updates of commit 21a34ed:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
[]() :x:Error Details
xml/Microsoft.Extensions.Logging/ILogger.xml :x:Error Details

xml/Microsoft.Extensions.Logging/ILogger.xml

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

learn-build-service-prod[bot] commented 2 months ago

Learn Build status updates of commit f490ee1:

:white_check_mark: Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Logging/ILogger.xml :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please: