search

dotnet / dotnet-api-docs

.NET API reference documentation (.NET 5+, .NET Core, .NET Framework)
https://docs.microsoft.com/dotnet/api/
Other
725 stars 1.56k forks source link

Changed String to string. IDE0049 #10384

Closed muhammadzakriashahid closed 1 month ago

muhammadzakriashahid commented 1 month ago

Summary

Describe your changes here. i change the String type to string. Because of the rule ID IDE0049 Use language keywords instead of framework type names for type references. Fixes #Issue_Number (if available)

learn-build-service-prod[bot] commented 1 month ago

Learn Build status updates of commit 5838cae:

:white_check_mark: Validation status: passed

File Status Preview URL Details
snippets/csharp/System/String/Replace/string.replace1.cs :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

BillWagner commented 1 month ago

tag @gewarren

I know that our general guideline is to use string vs. String. Do you want to follow that same guideline for the System.String APIs?

gewarren commented 1 month ago

tag @gewarren

I know that our general guideline is to use string vs. String. Do you want to follow that same guideline for the System.String APIs?

Yes, I don't see why not.

gewarren commented 1 month ago

@muhammadzakriashahid Can you add a project file similar to https://github.com/dotnet/dotnet-api-docs/blob/main/snippets/csharp/System/Math/E/Project.csproj but for .net8.0 in the directory that contains the snippet? This is a newer requirement that we enforce whenever a code snippet is modified so we can ensure it compiles.

muhammadzakriashahid commented 1 month ago

@dotnet-policy-service agree

learn-build-service-prod[bot] commented 1 month ago

Learn Build status updates of commit fbe367c:

:white_check_mark: Validation status: passed

File Status Preview URL Details
snippets/csharp/System/String/Replace/Project.csproj :white_check_mark:Succeeded
snippets/csharp/System/String/Replace/replace1.cs :white_check_mark:Succeeded View
snippets/csharp/System/String/Replace/replace2.cs :white_check_mark:Succeeded View
snippets/csharp/System/String/Replace/string.replace1.cs :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

muhammadzakriashahid commented 1 month ago

haven't heard from you guys

gewarren commented 1 month ago

Thanks @muhammadzakriashahid

learn-build-service-prod[bot] commented 1 month ago

Learn Build status updates of commit f9f16d7:

:white_check_mark: Validation status: passed

File Status Preview URL Details
snippets/csharp/System/String/Replace/Program.cs :white_check_mark:Succeeded
snippets/csharp/System/String/Replace/Project.csproj :white_check_mark:Succeeded
snippets/csharp/System/String/Replace/replace1.cs :white_check_mark:Succeeded View
snippets/csharp/System/String/Replace/replace2.cs :white_check_mark:Succeeded View
snippets/csharp/System/String/Replace/string.replace1.cs :white_check_mark:Succeeded View
snippets/csharp/System/String/Replace/stringreplace.cs :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please: