search

dotnet / dotnet-api-docs

.NET API reference documentation (.NET 5+, .NET Core, .NET Framework)
https://docs.microsoft.com/dotnet/api/
Other
725 stars 1.56k forks source link

Update `Histogram<T>` docs to note that `decimal` data will not be exported #10615

Open maxs-rose opened 4 days ago

maxs-rose commented 4 days ago

Describe the issue or suggestion

As per https://github.com/open-telemetry/opentelemetry-dotnet/issues/5615 when creating a Histogram<decimal> the data will not acutally be exported.

Since the generic type param will accept a decimal it could be best to just add a second remark that when using it the data wont actualy be exported? Of course just removing decimal from the current list of types would also work.

Current Docs: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics.histogram-1

Happy to make a pull request doing the work however, I am not entirely sure what should be done.

dotnet-issue-labeler[bot] commented 4 days ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 4 days ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.