search

dotnet / dotnet-buildtools-prereqs-docker

Used to maintain the Docker images hosted at the mcr.microsoft.com/dotnet-buildtools/prereqs image repository
MIT License
53 stars 99 forks source link

Y2038 support: Target Ubuntu 22.04 in arm build image #1037

Closed sbomer closed 1 month ago

sbomer commented 1 month ago

Fixes https://github.com/dotnet/dotnet-buildtools-prereqs-docker/issues/1034 Fixes https://github.com/dotnet/runtime/issues/96460

I'm still hitting some issues trying to validate this locally, so marking it no-merge for now.

richlander commented 1 month ago

Will you be able to merge this PR in time?

sbomer commented 1 month ago

Don't worry, I've got all the time in the world...

Before:

01/19/2038 03:14:05
01/19/2038 03:14:06
01/19/2038 03:14:07
01/01/1970 00:00:00
01/01/1970 00:00:00
01/01/1970 00:00:00

After:

01/19/2038 03:14:05
01/19/2038 03:14:06
01/19/2038 03:14:07
01/19/2038 03:14:08
01/19/2038 03:14:09
01/19/2038 03:14:10

(Validated with a local arm32 build against this change. The openssl shim also is linked against 64-bit versions of the time symbols.)

richlander commented 1 month ago

Well played, sir.

Context: This change is for Y2038 -> https://github.com/dotnet/core/discussions/9285

richlander commented 1 month ago

That change was simpler than I was guessing, but makes sense in hindsight.

sbomer commented 1 month ago

Blocked on https://github.com/dotnet/arcade/pull/14754