search

dotnet / dotnet-buildtools-prereqs-docker

Used to maintain the Docker images hosted at the mcr.microsoft.com/dotnet-buildtools/prereqs image repository
MIT License
53 stars 99 forks source link

Try 2: Split MSQuic building into a separate stage #1070

Closed jkoritzinsky closed 1 month ago

jkoritzinsky commented 1 month ago

First commit is #1064.

The second commit adds a missing dependency of libmsquic into the image, numactl. This was the only package that was installed as part of the msquic build and then not uninstalled. It's required by msquic to function.

wfurt commented 1 month ago

This still does not put the libraries into /usr/lib, right? So 1) it is different than all other platforms and 2) I don't think tests will find it. If you feel otherwise did you run Quic tests on produced image?

jkoritzinsky commented 1 month ago

It puts them into /lib. I'll update this PR to put them into usr/lib.

jkoritzinsky commented 1 month ago

@wfurt any more feedback?

ManickaP commented 1 month ago

I tested 3.18 amd64 from this PR, QuicConnection.IsSupported returned true, so it works.