search

dotnet / dotnet-buildtools-prereqs-docker

Used to maintain the Docker images hosted at the mcr.microsoft.com/dotnet-buildtools/prereqs image repository
MIT License
53 stars 102 forks source link

Attempt to fix sourcebuild issues #957

Closed wtgodbe closed 5 months ago

wtgodbe commented 6 months ago

Attempt to fix https://github.com/dotnet/source-build/issues/3925, https://github.com/dotnet/source-build/issues/3924

wtgodbe commented 6 months ago

Out of curiosity, what's the node&npm version on Fedora 39? And I assume you tested both changes?

I don't work with Docker much, so normally I use the images that get produced by the build of this repo - how can I test them out from the sources?

wtgodbe commented 6 months ago

8 9.908 Preparing to unpack .../nodejs_20.11.0-1nodesource1_amd64.deb ...

8 9.914 Unpacking nodejs (20.11.0-1nodesource1) over (12.22.9~dfsg-1ubuntu3) ...

8 11.45 dpkg: error processing archive /var/cache/apt/archives/nodejs_20.11.0-1nodesource1_amd64.deb (--unpack):

8 11.45 trying to overwrite '/usr/include/node/common.gypi', which is also in package libnode-dev 12.22.9~dfsg-1ubuntu3

8 11.47 dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)

8 11.48 Errors were encountered while processing:

8 11.48 /var/cache/apt/archives/nodejs_20.11.0-1nodesource1_amd64.deb

8 11.50 E: Sub-process /usr/bin/dpkg returned an error code (1)

@ViktorHofer was this why you mentioned having to remove node from the system in https://github.com/dotnet/source-build/issues/3924#issuecomment-1886811967?

ViktorHofer commented 6 months ago

Yes, exactly. But I wasn't sure if this is needed on docker. I thought that was specific to a bad machine state.

mthalman commented 6 months ago

Out of curiosity, what's the node&npm version on Fedora 39? And I assume you tested both changes?

I don't work with Docker much, so normally I use the images that get produced by the build of this repo - how can I test them out from the sources?

Instructions for building

mthalman commented 6 months ago 
#9 7.066 Unpacking nodejs (20.11.0-1nodesource1) ...
#9 8.642 dpkg: error processing archive /var/cache/apt/archives/nodejs_20.11.0-1nodesource1_amd64.deb (--unpack):
#9 8.642  trying to overwrite '/usr/include/node/common.gypi', which is also in package libnode-dev 12.22.9~dfsg-1ubuntu3
#9 8.662 dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
#9 8.671 Errors were encountered while processing:
#9 8.671  /var/cache/apt/archives/nodejs_20.11.0-1nodesource1_amd64.deb
#9 8.690 E: Sub-process /usr/bin/dpkg returned an error code (1)
wtgodbe commented 6 months ago

That's the same error as https://github.com/dotnet/dotnet-buildtools-prereqs-docker/pull/957#issuecomment-1894307239, @ViktorHofer it looks like the node uninstall isn't working, or is incomplete?

ViktorHofer commented 5 months ago

The uninstall worked for me locally on my Ubuntu 22.04 machine. Unsure what's required for this dockerfile.

wtgodbe commented 5 months ago

Alright, I think this is working now & feedback has been addressed.