search

dotnet / dotnet-buildtools-prereqs-docker

Used to maintain the Docker images hosted at the mcr.microsoft.com/dotnet-buildtools/prereqs image repository
MIT License
57 stars 103 forks source link

Use .NET 1ES hosted pool for public builds #984

Closed lbussell closed 6 months ago

lbussell commented 6 months ago

This should fix #983, by switching back to the 1ES pool for PR validation. Was removed in https://github.com/dotnet/dotnet-buildtools-prereqs-docker/pull/980/commits/fd31d1c3ccc8e3f9470187a2fc513b13ebe482c6

MichaelSimons commented 6 months ago

Are we going to encounter the disk space issues in internal?

lbussell commented 6 months ago

Are we going to encounter the disk space issues in internal?

Great question. We can't really know until we unblock the build, I guess. We can run a no-cache build of CBL mariner as a test. I queued it here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2409841&view=results

My hypothesis is that this is only an issue with the AzDo/GitHub hosted runners and that 1ES images/pools should be fine.

Also, This PR still seems to be resolving the hosted runner agent even after my change. I'll keep investigating.