search

dotnet / dotnet-docker-nightly

This repository has moved to the nightly branch of dotnet/dotnet-docker.
https://github.com/dotnet/dotnet-docker/tree/nightly
MIT License
35 stars 30 forks source link

Dummy commit. #432

Closed ravimeda closed 7 years ago

dnfclas commented 7 years ago

@ravimeda, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

ravimeda commented 7 years ago

@dotnet-bot test ci please.

MichaelSimons commented 7 years ago

@ravimeda - What was the purpose of this PR and why was this PR merged? I assume it was to test CI. If that was the case, then there is no need to merge it. We don't want to pollute the repo with files like this in addition to polluting the history. Please revert.

ravimeda commented 7 years ago

As discussed offline - practice of using dummy.txt is to invoke a CI test without touch any source code file. For example, in core-setup (https://github.com/dotnet/core-setup/blob/master/Documentation/dummy.txt). For dotnet/docker repos, we do not want to follow such practice.

@mmitche FYI.

MichaelSimons commented 7 years ago

core-setup has a checked in dummy.txt to trigger actual product builds. This is not needed for dotnet/docker.