search

dotnet / dotnet-docker-nightly

This repository has moved to the nightly branch of dotnet/dotnet-docker.
https://github.com/dotnet/dotnet-docker/tree/nightly
MIT License
35 stars 30 forks source link

xUnit Test to validate ARM images. #434

Closed ravimeda closed 7 years ago

ravimeda commented 7 years ago

Extending unit test coverage to ARM image. ARM unit test operates similar to the existing AMD64 tests. However, there are slight differences. ARM test does the following -

  1. Build an image using a base image that has .NET Core 2.0 SDK, and create a new console app.
  2. For FDD verification, publish the app to a Docker volume. Run the app on a -runtime-stretch-arm32v7 image.
  3. SCD verification is similar to FDD but a self-contained app is built the base image.

VerifyArmImages and VerifyImages has some duplicated code that I would like to avoid. Please let me know if you have suggestions.

dnfclas commented 7 years ago

@ravimeda, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot #Closed

ravimeda commented 7 years ago

Hopefully I got the changes merged correctly along with addressing PR feedback. Please let me know if something doesn't look aligned well. #Closed

ravimeda commented 7 years ago

@dotnet-bot test ci please.

MichaelSimons commented 7 years ago

@dotnet-bot Test NanoServer - 2.0 Dockerfiles please