dotnet / dotnet-docker-nightly

This repository has moved to the nightly branch of dotnet/dotnet-docker.

https://github.com/dotnet/dotnet-docker/tree/nightly

MIT License

35 stars 30 forks source link

Stop producing Nano Server Version suffixed tags. #455

Closed ravimeda closed 7 years ago

ravimeda commented 7 years ago

Removes Nano Version from non-fully qualified tags. Refer https://github.com/dotnet/dotnet-docker/issues/312

dnfclas commented 7 years ago

@ravimeda, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot #Closed

ravimeda commented 7 years ago

I think a more cleaner and simpler solution than 4109388 is -

    [ValidateSet('dotnet-docker','dotnet-docker-nightly')]
    [string]$RepoName='dotnet-docker-nightly'

This way the developer knows the choices. If none specified, then a default will be used by the script. #Closed

ravimeda commented 7 years ago

@dn-bot test NanoServer - 2.1 Dockerfiles please #Closed

MichaelSimons commented 7 years ago

I'm not crazy about the ValidateSet as only one is a valid option per repo and you would still be hard coding a default. I prefer the direction in the active changes.

Resolved

ravimeda commented 7 years ago

@dotnet-bot test NanoServer - 1. Dockerfiles please @dotnet-bot NanoServer - 2.0 Dockerfiles please @dotnet-bot NanoServer - 2.1 Dockerfiles please

ravimeda commented 7 years ago

@dotnet-bot NanoServer - 2.0 Dockerfiles please @dotnet-bot NanoServer - 2.1 Dockerfiles please

ravimeda commented 7 years ago

@dotnet-bot NanoServer - 2.0 Dockerfiles please @dotnet-bot NanoServer - 2.1 Dockerfiles please

MichaelSimons commented 7 years ago

@dotnet-bot test NanoServer - 2.0 Dockerfiles please @dotnet-bot test NanoServer - 2.1 Dockerfiles please