search

dotnet / dotnet-docker-nightly

This repository has moved to the nightly branch of dotnet/dotnet-docker.
https://github.com/dotnet/dotnet-docker/tree/nightly
MIT License
35 stars 30 forks source link

Add escape directive in Nano Server Dockerfiles #463

Closed ravimeda closed 7 years ago

ravimeda commented 7 years ago

Update Nano Server Dockerfile to use the escape directive (https://docs.docker.com/engine/reference/builder/#escape).

Tested these changes by running build-and-test.ps1 -Filter *nanoserver*. Tested the scope of the escape directive through the following sequence -

  1. Build an image using a Dockerfile that uses backtick as the escape directive. Say, image tag is backtick:latest
  2. Prepare a Dockerfile that uses backtick:latest. Add some additional commands in the Dockerfile that use \ backslash as the line continuation character.
  3. Build an image using the Dockerfile created in step #2. Expectation is a Dockerfile parse error due to \ character.
dnfclas commented 7 years ago

@ravimeda, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

MichaelSimons commented 7 years ago

Related to dotnet/dotnet-docker#311.