search

dotnet / dotnet-docker-nightly

This repository has moved to the nightly branch of dotnet/dotnet-docker.
https://github.com/dotnet/dotnet-docker/tree/nightly
MIT License
35 stars 30 forks source link

Add 2.1 Alpine images #480

Closed MichaelSimons closed 6 years ago

MichaelSimons commented 6 years ago

Related to dotnet/dotnet-docker#22

Image size on disk (MB):

alpine:3.6 3.97 2.1-runtime-deps-alpine ~43.9~ 13.8 2.1-runtime-alpine ~112~ 82.5

Note: self-contained apps are not yet working e2e therefore the test case for the runtime-deps is disabled.

cc @janvorli, @Petermarcu

MichaelSimons commented 6 years ago

@janvorli - Can you point me to the issue tracking Alpine support for self-contained apps or should I log one? I would like to track it so that I can enable the unit tests for the runtime-deps image once support is in place. Thanks

janvorli commented 6 years ago

@MichaelSimons there is none. I was first wondering what's the actual problem, but then I've remembered that @eerhardt has asked me to revert part of the core-setup change until we have the official corefx / coreclr builds and then I've completely forgotten about it. Let me create a PR for that missing piece right away.

MichaelSimons commented 6 years ago

@dotnet-bot test Debian - 1. Dockerfiles please

MichaelSimons commented 6 years ago

Linking to https://github.com/dotnet/core-setup/pull/3395 which will enable support for self-contained apps.

MichaelSimons commented 6 years ago

A decision was made to have the Alpine images make use of the Globalization Invariant Mode. The belief is the majority of Docker usage scenarios would prefer this mode. This eliminates the need for icu-lib which will reduce the runtime-deps image by 30.3 MB (also applies to the runtime image). Users can turn this option off and add the icu-lib package if needed.

MichaelSimons commented 6 years ago

The Globalization Invariant Mode changes are dependent on https://github.com/dotnet/coreclr/issues/14927. The Docker images need a way to enable the mode globally so that the out of box experience works since icu-lib will not be included.

ThatDeveloper commented 6 years ago

When is this going to be live?

MichaelSimons commented 6 years ago

@ThatDeveloper - waiting on the https://github.com/dotnet/coreclr/issues/14927 to make it into Core-Setup and picked up by the CLI. The images won't be available in microsoft/dotnet until 2.1 is released.

eerhardt commented 6 years ago

@MichaelSimons - FYI that change should be in the latest core-setup build: Microsoft.NETCore.App 2.1.0-preview1-25919-02.

MichaelSimons commented 6 years ago

@richlander - I think this is ready to merge. Are you good with that?

richlander commented 6 years ago

LGTM

We should post (after merge) on our call to action / ask for feedback. I'll talk to you about that.