search

dotnet / dotnet-docker-nightly

This repository has moved to the nightly branch of dotnet/dotnet-docker.
https://github.com/dotnet/dotnet-docker/tree/nightly
MIT License
35 stars 30 forks source link

libuv package from edge-repo #542

Closed oanogin closed 6 years ago

oanogin commented 6 years ago

"Runtime" image invalid due to the this image (runtime-deps), because it hasn't libuv package installed.

MichaelSimons commented 6 years ago

@janvorli - Can you take a look and comment? libuv wasn't in the original list of Alpine dependencies.

janvorli commented 6 years ago

Libuv is not a coreclr runtime dependency, it is a dependency of the ASP.NET Core. But I guess that the docker image needs to support ASP.NET Core too, so the addition makes sense.

MichaelSimons commented 6 years ago

@janvorli - thanks for info. ASP.NET Core has their own images although they haven't yet added preview images for alpine. My initial reaction is that libuv should be added within an ASP.NET Core specific image to avoid adding unnecessary packages to the core runtime images.

@natemcmaster, @richlander

natemcmaster commented 6 years ago

We're tracking aspnetcore support for alpine here: https://github.com/aspnet/Universe/issues/833. It's not yet a platform aspnetcore supports.

MichaelSimons commented 6 years ago

@oanogin - thanks for making a PR. As noted in the discussion, the libuv dependency is something that belongs in the ASP.NET Core images. This issue should be addressed with aspnet/Universe#833. Closing PR but feel free to discuss.