mthalman
commented
1 year ago Remaining work on this:
- [ ] Image Builder needs changes in order to publish an image info file to an AzDO repo instead of GitHub. Work has started on this at https://github.com/dotnet/docker-tools/tree/feature/azdo-versions but is incomplete.
- [ ] Dockerfile templates need to specify the internal registry when targeting an internal build. Uncompleted work has started on that at https://github.com/dotnet/dotnet-docker/tree/feature/internal-image-caching
- [ ] Need the ability to login with the service principal. Uncompleted work has started on this at https://github.com/dotnet/dotnet-docker/tree/feature/internal-login. This also requires some work in Image Builder because it sends requests to the registry to get manifest info: https://github.com/dotnet/docker-tools/blob/3879ac3c772f7040c4085495463d601e8a7ac954/src/Microsoft.DotNet.ImageBuilder/src/ManifestService.cs. We need to flow the credentials of the service principal to these requests.
In order to prevent building of unnecessary images, wasting compute and storage resources, the pipeline for internal .NET builds should support image caching. This requires being able to pull from the internal ACR where the "cached" images are stored.