dotnet / dotnet-docker

Docker images for .NET and the .NET Tools.
https://hub.docker.com/_/microsoft-dotnet
MIT License
4.49k stars 1.94k forks source link

Need sample that shows the installation of additional packages in chiseled scenarios #4811

Open mthalman opened 1 year ago

mthalman commented 1 year ago

Installing additional packages into a chiseled container is not a straightforward task due to the lack of a shell. The only documentation that exists currently which illustrates how to do this is at https://github.com/ubuntu-rocks/dotnet/issues/21#issuecomment-1225912006. We should clean that up and include that in our samples.

We then should update the link here to reference this new sample.

mthalman commented 1 year ago

The need for this is exemplified by https://github.com/dotnet/core/issues/8663.

Depending on the outcome of https://github.com/dotnet/dotnet-docker/issues/4804, we should use icu as the example of what to install. If we end up producing images with icu, then that would be irrelevant and can target a different commonly used package instead.

richlander commented 1 year ago

I suggest we disconnect the icu conversation from this one. It's possible that we'll fully cover the ICU space. As you've raised, there is still tzdata and many other libraries that people might want.

I suggest you create a sample for icu and tzdata. That's relevant now. Perhaps, we'll removed icu from it later.

mthalman commented 1 year ago

The documentation should include notes on identifying that the desired package is defined as a slice and using it via chisel. And also handle a scenario where the desired package is not defined as a slice and describe how to include it via regular package installation.

tboby commented 1 year ago

Are there any samples in issues or docs which demonstrate how to add extra packages using the new chisel-wrapper and update the dpkg/status file?

It looks like the tooling has changed since the decision to provide ICU as an official build was made, so all the discussions don't seem to quite line up anymore!

Context: I'm looking to add dependencies for OpenCvSharp

mthalman commented 1 year ago

@tboby - We're following up on that at https://github.com/ubuntu-rocks/dotnet/issues/21#issuecomment-1791614707. Ultimately, we believe such documentation should be provided in a repo outside the context of just .NET as it is more of a fundamental issue between Chisel and container images in general.

lbussell commented 6 months ago

There is a new issue for tracking this request on the chisel repo: https://github.com/canonical/chisel/issues/118