dotnet / dotnet-docker

Docker images for .NET and the .NET Tools.
https://hub.docker.com/_/microsoft-dotnet
MIT License
4.42k stars 1.93k forks source link

Use default NuGet configuration for scenario tests #5787

Closed lbussell closed 1 week ago

lbussell commented 1 month ago

This is the preferred solution to https://github.com/dotnet/dotnet-docker/issues/5704. In order to more accurately validate user experience, we should use the default NuGet configuration for scenario tests in both main and nightly (except for pre-release versions of .NET, which require a special NuGet feed).

The relevant NuGet configs that we use today are here:

Once this is complete, the workaround from https://github.com/dotnet/dotnet-docker/pull/5786 should be removed.

lbussell commented 3 weeks ago

[Triage] We should continue to use the internal mirror feeds for the nightly repo.

We should also make sure to clean up the feeds for the servicing versions of .NET in the nightly branch, since we are no longer testing pre-release versions of those .NET versions in the nightly branch.

https://github.com/dotnet/dotnet-docker/blob/5492718d4ddb6949b3853aac148b784a6572c8fe/tests/Microsoft.DotNet.Docker.Tests/TestAppArtifacts/NuGet.config.nightly#L5-L6