search

dotnet / dotnet-docker

Docker images for .NET and the .NET Tools.
https://hub.docker.com/_/microsoft-dotnet
MIT License
4.49k stars 1.94k forks source link

Add Aspire Dashboard 9.0 RC1 images #5980

Closed joperezr closed 1 month ago

joperezr commented 1 month ago

.NET Aspire 9.0 RC1 will be released soon, so we'll want a nightly image with its contents to be published as well.

dotnet-issue-labeler[bot] commented 1 month ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-issue-labeler[bot] commented 1 month ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

joperezr commented 1 month ago

I think there are still some changes needed here @lbussell, as we don't want 9.0 image to replace 8.2 one just yet as 9.0 one won't be stable. So the idea would be to have 9.0 prerelease and 8.2.1 side by side, and then when 9.0 ships stable we can remove the 8.2 one.

lbussell commented 1 month ago

There was an issue with the Build command when there are no arch-specific tags - 

Unhandled exception: System.InvalidOperationException: Sequence contains no matching element
   at System.Linq.ThrowHelper.ThrowNoMatchException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.DotNet.ImageBuilder.Commands.BuildCommand.PublishImageInfoAsync() in /image-builder/src/Commands/BuildCommand.cs:line 200
   at Microsoft.DotNet.ImageBuilder.Commands.BuildCommand.<ExecuteAsync>b__18_0() in /image-builder/src/Commands/BuildCommand.cs:line 101

This is something we should sort out separately from the Aspire Dashboard update. To unblock the PR, the arch-specific tags can be added back for now.

joperezr commented 1 month ago

Awesome! thank you so much for all the hard work on getting this through @lbussell !! really appreciate it!