dotnet / dotnet-wasi-sdk

An SDK for building .NET projects as standalone WASI-compliant modules
MIT License
279 stars 12 forks source link

Errors finding System.Runtime.CompilerServices.NullableAttribute #30

Open kkukshtel opened 8 months ago

kkukshtel commented 8 months ago

Error dump:

Can't find custom attr constructor image: Dinghy.dll mtoken: 0x0a00001a due to: Could not resolve type with token 01000016 from typeref (expected class 'System.Runtime.CompilerServices.NullableAttribute' in assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Runtime.CompilerServices.NullableAttribute member:(null)
[wasm_trace_logger] Can't find custom attr constructor image: Dinghy.dll mtoken: 0x0a00001a due to: Could not resolve type with token 01000016 from typeref (expected class 'System.Runtime.CompilerServices.NullableAttribute' in assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Runtime.CompilerServices.NullableAttribute member:(null)
Assertion failed: 0 (/home/runner/work/dotnet-wasi-sdk/dotnet-wasi-sdk/modules/runtime/src/mono/wasi/mono-wasi-driver/driver.c: get_native_to_interp: 408)

Seems like System.Runtime.CompilerServices.NullableAttributecan't be found? Tried running with wasmer/wasmtime and same error. The build built without issue. I'm just dipping my toes in here as well so not sure how to even start debugging this.

Russell-Horwood commented 6 months ago

I'm Just dipping my toe in here too but to me this to not be implemented in the commit of dotnet-wasi-runtime that this repo references. And it's still not in the latest version either, and I reckon that's because dotnet-wasi-runtime was forked from the dotnet-runtime before NullableAttribute was added for .NET8.

HermanSchoenfeld commented 5 months ago

Yes, definitely an issue due to newly added NullableAwareContext attribute in .NET 8.