search

dotnet / ef6

This is the codebase for Entity Framework 6 (previously maintained at https://entityframework.codeplex.com). Entity Framework Core is maintained at https://github.com/dotnet/efcore.
https://docs.microsoft.com/ef/ef6
MIT License
1.41k stars 538 forks source link

fix for broken NuGet package #2263

Closed ErikEJ closed 3 weeks ago

ErikEJ commented 3 weeks ago

fixes #2262

@AndriySvyryd FYI 😭

ErikEJ commented 3 weeks ago

I have confirmed locally that this change broke the package (and that this fix produces a valid package)

AndriySvyryd commented 3 weeks ago

@ErikEJ Please rebase on release/6.5

ErikEJ commented 3 weeks ago

@AndriySvyryd How do I do that from my branch? (Excuse my ignorance) - with git cli

AndriySvyryd commented 3 weeks ago

Something like git rebase upstream/release/6.5 -i Assuming that the remote for this repo is called upstream

ErikEJ commented 3 weeks ago

@AndriySvyryd That di not go so well - let me start over

birbilis commented 2 weeks ago

got bit too by the previous NuGet package (wasn't removing old entries from files and was also creating some configuration subfolders), had to rollback via version control and install the new one which works fine (upgrading to new package wasn't solving the mess). Maybe rolling back to previous NuGet package might have worked too, but not sure