search

dotnet / ef6tools

This is the codebase for the Entity Framework 6 and LINQ-To-SQL designers.
MIT License
35 stars 14 forks source link

UI thread #39

Closed ryanbrandenburg closed 2 years ago

ryanbrandenburg commented 2 years ago

We might be off the UI thread in some instances, but IsDocumentInProject demands it. Be sure to switch.

ryanbrandenburg commented 2 years ago

As best I can tell this was actually fixed by https://github.com/dotnet/ef6tools/commit/5f2a6249dff6aa9d6fdddefc504519d098ce0200, our testing must have been in a weird state because when I try 17.4 (which has 5f2a6249dff6aa9d6fdddefc504519d098ce0200, but not d0a651f1ecf0387d93ebcd4c09960a12e0334abf ) the issue is fixed. On consultation with @jasonmalinowski the above is sort of a no-op.

Unfortunately we inserted this d0a651f1ecf0387d93ebcd4c09960a12e0334abf due to some hand-off confusion on my part so the commit needs to be preserved. So I've reverted, then will merge the PR and insert again.