search

dotnet / ef6tools

This is the codebase for the Entity Framework 6 and LINQ-To-SQL designers.
MIT License
35 stars 14 forks source link

Modernize EF6Tools repo #67

Closed phil-allen-msft closed 3 months ago

phil-allen-msft commented 3 months ago

Modernize EF6Tools repo

Update EntityFramework packages from 6.2.0 to 6.5.1 Remove checked in copy of ef6 code Enable tests to run in VS Enable tests to pass in VS2019 and VS2022 In order to accommodate using the official binaries and their public APIs it does cause disabling around 10% of tests, but those 10% were not previously running anyway.

maryamariyan commented 3 months ago

@phil-allen-msft I'd love to review this, but the diff seems too large in the Files Changed tab.

Is it possible to break the diff into smaller chunks? The GitHub browser struggles with loading the diffs in one commit. If the deleted files are a significant part of the diff, could you please separate them into their own commit? This would make it easier to review the rest.

phil-allen-msft commented 3 months ago

@phil-allen-msft I'd love to review this, but the diff seems too large in the Files Changed tab.

Is it possible to break the diff into smaller chunks? The GitHub browser struggles with loading the diffs in one commit. If the deleted files are a significant part of the diff, could you please separate them into their own commit? This would make it easier to review the rest.

I certainly did the removal in order to find all the uses (and make all those changes), but splitting the commits was quick.