search

dotnet / ef6tools

This is the codebase for the Entity Framework 6 and LINQ-To-SQL designers.
MIT License
34 stars 13 forks source link

Make updates to get CI build fully passing #68

Closed phil-allen-msft closed 3 weeks ago

phil-allen-msft commented 3 weeks ago

After merging previous changes, found that local build tends towards EFTools.sln, but the CI is using EFTools.msbuild. Replicated build command for EFTools.msbuild and several listed after it in the yml for CI.

maryamariyan commented 3 weeks ago

After merging previous changes, found that local build tends towards EFTools.sln, but the CI is using EFTools.msbuild. Replicated build command for EFTools.msbuild and several listed after it in the yml for CI.

How do these changes affect the CI pipeline? Have some CI configurations been updated too?

phil-allen-msft commented 3 weeks ago

After merging previous changes, found that local build tends towards EFTools.sln, but the CI is using EFTools.msbuild. Replicated build command for EFTools.msbuild and several listed after it in the yml for CI.

How do these changes affect the CI pipeline? Have some CI configurations been updated too?

No change in CI configuration; it was a matter of local builds were done with the SLN file open, but the CI uses the EFTools.msbuild which calls EFTools.sln. Success in the SLN did not translate into success in the CI, and at the time the "check" for a passing CI build was disabled (now restored).