OData functional tests use transitive references from IdentityServer

dotnet / efcore

EF Core is a modern object-database mapper for .NET. It supports LINQ queries, change tracking, updates, and schema migrations.

https://docs.microsoft.com/ef/

MIT License

13.82k stars 3.2k forks source link

OData functional tests use transitive references from IdentityServer #23739

Closed ajcvickers closed 3 years ago

ajcvickers commented 3 years ago

While working on #20547, I removed the reference to IdentityServer from the SQL Server functional projects.

<PackageReference Include="IdentityServer4.EntityFramework" Version="4.1.1" />

This caused the OData tests to fail due to some transitive dependencies on ASP.NET Core being used. I failed to figure out specifically which dependencies were being used, so I added the reference directly in the OData tests and filed this bug to follow up.

smitpatel commented 3 years ago

IdentityServer depended on an older version of shared framework which brought in certain MVC types like HttpGetAttribute/ControllerBase/ModelBinderAttribute. Using shared framework directly in the project using Web SDK gets those missing references.