Implement average aggregation for `decimal` in SQLite

ranma42 commented 2 weeks ago

Contributes to https://github.com/dotnet/efcore/issues/19635

[x] I've read the guidelines for contributing and seen the walkthrough
[x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
[x] The code builds and tests pass locally (also verified by our automated build checks)

[x] Commit messages follow this format:

    Summary of the changes
    - Detail 1
    - Detail 2

    Fixes #bugnumber

(well, "Contributes" instead of "Fixes")

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Code follows the same patterns and style as existing code in this repo

ranma42 commented 2 weeks ago

I also posted #33721. This PR is slightly simpler as it does not affect the nullability processing, but I left it as a draft as I still have some (similar) doubts around both these changesets. I'll update both PRs later on 😇

roji commented 2 weeks ago

@ranma42 I'd suggest submitting a single PR for the multiple aggregate translations; things are similar enough that it makes sense to just have a single PR I think.

dotnet / efcore

Implement average aggregation for `decimal` in SQLite #33720