Add missing awaits in MigrationsInfrastructureTestBase

dotnet / efcore

EF Core is a modern object-database mapper for .NET. It supports LINQ queries, change tracking, updates, and schema migrations.

https://docs.microsoft.com/ef/

MIT License

13.8k stars 3.2k forks source link

Add missing awaits in MigrationsInfrastructureTestBase #35106

Closed roji closed 1 week ago

roji commented 1 week ago

Introduced in #34869.

This one was fun to investigate...

ajcvickers commented 1 week ago

I tried to find all cases of this a few months ago. Guess I failed! :-)

roji commented 1 week ago

Nothing like hangs and low-level protocol corruption errors in your EF tests to get your day going :)

roji commented 1 week ago

We should backport this right? This should affect test stability in a bad way - it causes EFCore.PG tests to fail really systematically, am surprised it doesn't do the same for SQL Server...

ajcvickers commented 1 week ago

We should backport this right?

Yes. I have never been able to predict when the failures/hangs from this pattern show up, but they will for someone and it will be infuriating! So yes, fix everywhere. :-D