dotnet / extensions

This repository contains a suite of libraries that provide facilities commonly needed when creating production-ready applications.
MIT License
2.62k stars 751 forks source link

Combine the ComplianceReports and MetricDefinitions generators #3999

Open danmoseley opened 1 year ago

danmoseley commented 1 year ago

Let's combine both of these generators into MetadataExtractor which produces a single json document containing:

All logging methods in the assembly, with their data compliance annotations All data models in the assembly which are annotation with data compliance annotations. All metrics defined in the assembly Along with any other schematized information we can extract programmatically.

IbrahimMNada commented 6 days ago

I will work on it

IbrahimMNada commented 4 days ago

Fixed at https://github.com/dotnet/extensions/pull/5531

I have added a new generator called MetadataExtractor which handle both generators into one json. its just a wrapper on top of the emitter of both Metric ,Compliance

I have also written full unit tests for it Image

handled the three cases in which Metric was enabled or Compliance or both
Image

I have added new properties for them as well

MetadataReportOutputPath GenerateMetadataReport