Closed klauco closed 1 year ago
cc @geeknoid @xakep139 @noahfalk
As @noahfalk suggested, we should consider using instrument names that follow pattern like: aspnetcore.header_parsing.parse_errors
instead of HeaderParsing.ParsingErrors
that we have currently.
I can apply this pattern within #4342, but we need to reach an agreement first
As @noahfalk suggested, we should consider using instrument names that follow pattern like:
aspnetcore.header_parsing.parse_errors
instead ofHeaderParsing.ParsingErrors
that we have currently.
We have also aligned the naming in Polly with OpenTelemetry by using the convention as suggested above. See https://github.com/App-vNext/Polly/pull/1583 for reference.
Also attributes names were changed:
event_name
-> event.name
exception_name
-> exception.type
(this one is standard in OT)Up-to-date conventions are here: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md
@xakep139 is working on this this week, and the target is to merge by next week.
Update:
Currently, the metric names are using backslashes. OTel uses dots. We need to go through the metrics and ensure we stick to the same naming convention (and semantic grouping as part of the metric name).
Proposal: