dotnet / extensions

This repository contains a suite of libraries that provide facilities commonly needed when creating production-ready applications.
MIT License
2.66k stars 755 forks source link

Logging generator in Microsoft.Extensions.Telemetry.Abstractions should have a code fixer that matches the platform's logging generator. #4761

Open joperezr opened 11 months ago

joperezr commented 11 months ago

As explained in the package's README, Microsoft.Extensions.Telemetry.Abstractions includes a logging generator that replaces the one from Microsoft.Extensions.Logging.Abstractions as it supersedes it by adding more features to it. One thing that was noticed, is that the platform one contained code fixers and analyzers that would help you to detect when the generator is used, as well as a fixer that would help make the changes for you, but the new Microsoft.Extensions.Telemetry.Abstractions package doesn't have those. This means that we are regressing this experience for users that opt-in to our extended generator capabilities.

We should make sure that the features from the package on this repository, are a full superset of the features in the platform so as to not regress any scenarios. This issue is tracking the work to add those analyzers and features into the Microsoft.Extensions.Telemetry.Abstractions package.

cc: @geeknoid

joperezr commented 11 months ago

FYI: @tarekgh and @noahfalk