search

dotnet / extensions

This repository contains a suite of libraries that provide facilities commonly needed when creating production-ready applications.
MIT License
2.68k stars 757 forks source link

Generalise how package version isn't stabilized for dev/preview stages #5640

Open RussKie opened 1 week ago

RussKie commented 1 week ago

Follow up on #5632

Microsoft Reviewers: Open in CodeFlow
joperezr commented 3 days ago

Also, I'm assuming you did, but in case not you should be able to validate if this works by running build.cmd -ci -pack /p:OfficialBuildId=20241212.01

RussKie commented 19 hours ago

build.cmd -ci -pack /p:OfficialBuildId=20241212.01

This command doesn't work (don't ask me how I know).

 D:\Development\dotnet-extensions\.dotnet\sdk\9.0.100-rtm.24479.2\NuGet.RestoreEx.targets(19,5): error :
      '9.1.0-preview.1.24612.01' is not a valid version string. (Parameter 'value')

The following do:

.\build.cmd -ci -restore
.\build.cmd -ci -build /p:OfficialBuildId=20241120.4
.\build.cmd -ci -pack /p:Restore=false /p:Build=false /p:OfficialBuildId=20241120.4

I added a pack-time check to ensure the version suffix is correct: image