search

dotnet / extensions

This repository contains a suite of libraries that provide facilities commonly needed when creating production-ready applications.
MIT License
2.64k stars 753 forks source link

GetFullPath should use concatenation #837

Closed aspnet-hello closed 5 years ago

aspnet-hello commented 6 years ago

From @glennc on Wednesday, January 21, 2015 3:06:32 PM

GetFullPath can concatenate instead of doing Path.Combine. This saves us from situations where Path.Combine will ignore part of the provided path if it is rooted.

Method should fail if someone is asking for a rooted file. Once this is done then GetFileInfo can also have unnecessary guard clauses removed.

// @blowdart

Copied from original issue: aspnet/FileSystem#39

aspnet-hello commented 5 years ago

Thanks for your feedback. We appreciate your letting us know about the problem you've encountered or suggestion but we are not planning to take further action on this issue because our focus has been on issues with significantly higher customer interest and issues impacting a broad number of customers.